Skip to content

Test against prereleases #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

Test against prereleases #683

merged 1 commit into from
Jun 1, 2022

Conversation

@jarrodmillman
Copy link
Collaborator

@jarrodmillman jarrodmillman commented May 28, 2022 •
edited
Loading

We should probably use

python -m pip install --pre -e .

instead of

python -m pip install --upgrade --pre -e .

I.e., without the --upgrade. But I wanted to test with upgrades to see if there were some potential upper pins that I should investigate. Thoughts?
@jarrodmillman jarrodmillman mentioned this pull request May 28, 2022
Closed
@jarrodmillman jarrodmillman marked this pull request as draft May 28, 2022 14:43
@jarrodmillman jarrodmillman marked this pull request as ready for review May 28, 2022 14:55
@jarrodmillman jarrodmillman marked this pull request as draft May 28, 2022 14:56
@jarrodmillman jarrodmillman force-pushed the prerelease branch 2 times, most recently from 24ad09c to 4050b7c Compare May 28, 2022 15:00
@choldgraf
Copy link
Collaborator

choldgraf commented May 28, 2022

This definitely makes sense to me - thanks for tracking down the weird pinning behavior.
@jarrodmillman
Copy link
Collaborator Author

jarrodmillman commented May 28, 2022

The more I think about it, the more I think maybe we should keep the --upgrade option. If it ends up causing too much noise, we can revisit.
@choldgraf
Copy link
Collaborator

choldgraf commented May 28, 2022

I'm not sure I understand the implications of --upgrade vs not, so I defer to your and others' expertise!
@jarrodmillman jarrodmillman marked this pull request as ready for review May 28, 2022 21:49
larsoner
larsoner approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've used --upgrade --pre in other repos for the past couple of years to catch problems ahead of time
@choldgraf choldgraf merged commit 2e8f415 into pydata:main Jun 1, 2022
@choldgraf
Copy link
Collaborator

choldgraf commented Jun 1, 2022

Let's do it!
larsoner added a commit to larsoner/pydata-sphinx-theme that referenced this pull request Jun 1, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into findall
fd0ae5e 
* upstream/main: Test against prereleases (pydata#683)
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jarrodmillman @choldgraf @larsoner