Skip to content

Update serialization warning tests with faulty values #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update serialization warning tests with faulty values #10085

merged 2 commits into from
Aug 12, 2024

Conversation

BoxyUwU
Copy link
Contributor

@BoxyUwU BoxyUwU commented Aug 8, 2024

In pydantic/pydantic-core#1377 the warning when providing a wrongly typed value for serialization was changed. This PR updates pydantic's tests to check for the new warning

cc @sydney-runkle
@github-actions github-actions bot added the relnotes-change Used for changes to existing functionality which don't have a better categorization. label Aug 8, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10085 will not alter performance

Comparing boxy/ser_warning_change (4d7ea73) with main (bf710b9)

Summary

✅ 17 untouched benchmarks
sydney-runkle
sydney-runkle suggested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - let's mark these tests with @pytest.mark.xfail(reason='blah blah blah') with a reason explaining that these will pass once we use the next pydantic-core version :).
@pydantic-hooky pydantic-hooky bot added the awaiting author revision awaiting changes from the PR author label Aug 8, 2024
@BoxyUwU BoxyUwU removed their assignment Aug 8, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d7ea73
Status: ✅  Deploy successful!
Preview URL: https://0ece2a7f.pydantic-docs.pages.dev
Branch Preview URL: https://boxy-ser-warning-change.pydantic-docs.pages.dev

View logs
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.
sydney-runkle
sydney-runkle approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @BoxyUwU, first contribution to pydantic!!!
@sydney-runkle sydney-runkle merged commit cb3ac5a into main Aug 12, 2024
@sydney-runkle sydney-runkle deleted the boxy/ser_warning_change branch August 12, 2024 13:59
@sydney-runkle sydney-runkle changed the title Update tests for changes to core Update serialization warning tests with faulty values Aug 12, 2024
@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed awaiting author revision awaiting changes from the PR author relnotes-change Used for changes to existing functionality which don't have a better categorization. labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

2 participants

@BoxyUwU @sydney-runkle