Skip to content

feat: support inferring media types from URLs with query params/fragments #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
h0rv wants to merge 4 commits into from
Closed

feat: support inferring media types from URLs with query params/fragments #3686

h0rv wants to merge 4 commits into from

Conversation

@h0rv
Copy link
Contributor

@h0rv h0rv commented Dec 9, 2025 •
edited
Loading

Currently, pydantic-ai cannot infer media type for presigned S3 URLs due to the query parameters added to the URL. This improves the infer method to check just the base URL (query parameters and fragments stripped).
@h0rv
Copy link
Contributor Author

h0rv commented Dec 9, 2025

We can also use urlib from the std lib if we want to introduce a new dep:

from urllib.parse import urlparse def base_url(url: str) -> str: return urlparse(url)._replace(query="", fragment="").geturl()
@h0rv
Copy link
Contributor Author

h0rv commented Dec 9, 2025

whoops - this is a dupe of #3501
@h0rv h0rv closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@h0rv