Feat: allow saving password in OS keychain/keyring #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I found them hard to read, used isort_ on default settings .. _isort: https://github.com/timothycrosley/isort
hdost approved these changes May 31, 2019
Contributor Author
| Hi @pycontribs , shall we merge make a new release 2.0.1 that includes this feature ^ as well as dozens of commits from 2019 ? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
resolves #784
Considering one thing we could change, is to move the keyring lookup logic inside the JIRA class, so that it's available to library users as well as shell users ...
@ssbarnea how do you feel about this?