Skip to content

ensure None is handled correctly in search_issues() #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022
Merged

ensure None is handled correctly in search_issues() #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jira/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,6 +2927,8 @@ def search_issues(
"""
if isinstance(fields, str):
fields = fields.split(",")
elif fields is None:
fields = ["*all"]

# this will translate JQL field names to REST API Name
# most people do know the JQL names so this will help them use the API easier
Expand Down
9 changes: 8 additions & 1 deletion tests/resources/test_issue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,17 @@ def test_issue_search_only_includes_provided_fields(self):
self.assertFalse(hasattr(issues[0].fields, "reporter"))

def test_issue_search_default_behaviour_included_fields(self):
issues = self.jira.search_issues("key=%s" % self.issue_1)
search_str = f"key={self.issue_1}"
issues = self.jira.search_issues(search_str)
self.assertTrue(hasattr(issues[0].fields, "reporter"))
self.assertTrue(hasattr(issues[0].fields, "comment"))

# fields=None should be valid and return all fields (ie. default behavior)
self.assertEqual(
self.jira.search_issues(search_str),
self.jira.search_issues(search_str, fields=None),
)

def test_issue_get_field(self):
issue = self.jira.issue(self.issue_1)
self.assertEqual(
Expand Down