Add notify to comment

[studioj]

my own implementation of #1008

I didn't want to add the functionality to jira.add_comment since I'm not sure if it has the same way of adding the notification as add_user => data["notification"]='false' OR data["notifyUsers"] = "false"

[studioj]

@adehad how do I ignore this since i don't want to change the api i don't think it's smart to listen to mypy here.
I think it's complaining about the order of the args but if people are using the kwargs as positional args we break the api

jira/resources.py:766: error: Signature of "update" incompatible with supertype "Resource" [override] jira/resources.py:766: note: Superclass: jira/resources.py:766: note: def update(self, fields: Optional[Dict[str, Any]] = ..., async_: Optional[bool] = ..., jira: Optional[JIRA] = ..., notify: bool = ..., **kwargs: Any) -> Any jira/resources.py:766: note: Subclass: jira/resources.py:766: note: def update(self, fields: Optional[Dict[str, Any]] = ..., async_: Optional[bool] = ..., jira: Optional[JIRA] = ..., body: str = ..., visibility: Optional[Dict[str, str]] = ..., is_internal: bool = ..., notify: bool = ...) -> Any 

i will add a @typing.no_type_check decorator

[crimsonxiii]

more for myself, but why the quotes around JIRA?
I didn't see such a variant on https://docs.python.org/3/library/typing.html

[adehad]

This is because we only import the JIRA class when type checking, and current Python versions actually try to evaluate the type hint.

Some more reading here: https://mypy.readthedocs.io/en/stable/runtime_troubles.html#annotation-issues-at-runtime

[adehad]

Looks good, one main suggestion about the type hinting

[adehad]

This is because we only import the JIRA class when type checking, and current Python versions actually try to evaluate the type hint.

Some more reading here: https://mypy.readthedocs.io/en/stable/runtime_troubles.html#annotation-issues-at-runtime

[studioj]

@adehad would be nice if this is released "soon" (maybe together with the other approved PR) my team would really like to use this feature :-)
I don't know the effort to release, glad to help if needed

[adehad]

@studioj yep I think a new release is due soon too! I'll also make progress on my PR, would be great if you can review it once I've made the changes