Locate the exact user by key if there are multiple users returned from query #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix get_user_id to check key also if there are multiple matches
adehad requested changes Sep 17, 2021
Contributor
adehad left a comment
adehad left a comment There was a problem hiding this comment.
Looks mostly fine to me. Can I confirm the situation is: you are searching by the exact key and you aren't getting it from the first result?
Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
for more information, see https://pre-commit.ci
adehad requested changes Oct 6, 2021
studioj added the Status: Needs Rework update per review comments. Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
studioj approved these changes Jan 15, 2022
adehad approved these changes Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously only the first user is taken when an issue is assigned, things would stop working when multiple user records are returned from server, and intended user is not listed at the head of result list.
A second filter is applied if multiple user records are returned, so if there is an exact match, it should be returned instead of the first one in original query list.