Skip to content

Conversation

tkoyama010
Copy link
Member

ref #352

@tkoyama010 tkoyama010 marked this pull request as draft April 20, 2025 03:25
@tkoyama010 tkoyama010 marked this pull request as ready for review April 20, 2025 03:42
@tkoyama010 tkoyama010 requested a review from flpm April 20, 2025 23:04
@lwasser
Copy link
Member

lwasser commented May 1, 2025

hey @tkoyama010 before you merge any of these other pr's there is something breaking CI on the japanese translation side of things.

https://github.com/pyOpenSci/python-package-guide/actions/runs/14626868364/job/41040382278?pr=467#step:12:42

can you please make sure that these items are fixed before merging? I can help with the english side of things as i see a few things might be on that end. many thanks!! 🚀

Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation builds correctly

@flpm flpm merged commit 1418316 into main May 19, 2025
4 checks passed
@flpm flpm deleted the tests branch May 19, 2025 17:40
@flpm flpm added the lang-JA label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants