allow multiple values for some properties if language differs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
htgoebel reviewed Jan 2, 2025
| @@ -1,5 +1,6 @@ | |||
| from . import base | |||
| | |||
| properties_allow_localization = ['NAME','SUMMARY','DESCRIPTION','LOCATION'] | |||
There was a problem hiding this comment.
PROPERTIES_ALLOW_LOCALIZATION = set('NAME','SUMMARY','DESCRIPTION','LOCATION') Comment on lines +104 to +107
| if name in language_count: | ||
| language_count[name][lang] = language_count[name].get(lang, 0) + 1 | ||
| else: | ||
| language_count[name] = {lang: 1} |
There was a problem hiding this comment.
Either only line 105 and no if-statement at all, or change line 105 to
language_count[name][lang] += 1 since you ensured that it exists in line 104
Author
| For vCards, the current IETF solution to this problem is the use of the ALTID tag, as specified in RFC-6350 aka vCard-4.0. However, as of v0.9.9 and v1.0.0pre, we don't yet support vCard-4.0. So far as I can see, RFC-2426 aka vCard-3.0 has no specified way of supporting more than one translated value for the same property. That said, it appears that the LANGUAGE tag is valid for any property. For iCalendar, RFC-5545 specifies the LANGUAGE parameter. It's allowed on:
Note that no NAME property exists for iCalendar, nor vCard. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR skarim#189