Pullrequest dtstart exdate tz fix #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed exception 'TypeError: can't compare offset-naive and offset-aware datetimes' triggered when DTSTART and EXDATE not both have or not have timez one information. Fix will propagte time zone information from from DTSTART to EXDATE if EXDATE does not have a TZ or strip the TZ from EXDATE when DTSTART does not have time zone information.
htgoebel suggested changes Jan 2, 2025
| if isinstance(dtstart, datetime.datetime): | ||
| dtstart_tzinfo = dtstart.tzinfo | ||
| else: | ||
| dtstart_tzinfo = None |
There was a problem hiding this comment.
Please move this into the if name in DATENAMES: clause since it is only used in that case.
| elif type(line.value[0]) == datetime.date: | ||
| for dt in line.value: | ||
| addfunc(datetime.datetime(dt.year, dt.month, dt.day)) | ||
| if isinstance(dtstart, datetime.datetime): |
There was a problem hiding this comment.
Why is this test different from the one for datetime (line 440)?
| if dtstart_tzinfo is None: | ||
| addfunc(dt.replace(tzinfo=None)) | ||
| else: | ||
| addfunc(dt) |
There was a problem hiding this comment.
Please move the test outside the loop. This makes the code more efficient.
Same below.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue skarim#139
PR skarim#146