Skip to content

Add analytical azimuth method to solarposition.py. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 1, 2017
Merged

Add analytical azimuth method to solarposition.py. #349

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
52cfb3b
Add analytical azimuth method.
veronicaguo Jul 14, 2017
5395164
Number linked references.
veronicaguo Jul 24, 2017
4e56576
Add test for solar_azimuth_analytical.
veronicaguo Jul 24, 2017
c0698d4
Add an entry in the api.rst file.
veronicaguo Jul 24, 2017
e3c7530
Correct for different azimuth convention.
veronicaguo Jul 24, 2017
9c2b89b
Update test tolerance.
veronicaguo Jul 24, 2017
b6d6fb9
Added an entry in the v0.4.6 whatsnew file.
veronicaguo Jul 24, 2017
d1b38b5
Update assert statements.
veronicaguo Jul 25, 2017
2c346c4
Update threshold for `atol=0.55` assert statement.
veronicaguo Jul 26, 2017
3728f15
Merge branch 'master' of github.com:pvlib/pvlib-python
veronicaguo Jul 27, 2017
31bf30d
Update test, only when the sun is above horizon.
veronicaguo Jul 27, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update assert statements.
  • Loading branch information
@veronicaguo
veronicaguo committed Jul 25, 2017
commit d1b38b5fbbf2d05ea2d6c2bc0710177699822bef
29 changes: 15 additions & 14 deletions pvlib/test/test_solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,17 +443,18 @@ def test_analytical_azimuth():
zenith = solarposition.solar_zenith_analytical(lat_rad, hour_angle, decl)
azimuth_2 = solarposition.solar_azimuth_analytical(lat_rad, hour_angle,
decl, zenith)
for idx, a in enumerate(azimuth_1):
if a < 0.7:
assert np.allclose(a, solar_azimuth[idx], atol=0.025) or \
np.allclose(a + np.pi * 2, solar_azimuth[idx], atol=0.55)
else:
assert np.allclose(a, solar_azimuth[idx], atol=0.025)

for idx, a in enumerate(azimuth_2):
if a < 0.7:
assert np.allclose(a, solar_azimuth[idx], atol=0.025) or \
np.allclose(a + np.pi * 2, solar_azimuth[idx], atol=0.55)
else:
assert np.allclose(a, solar_azimuth[idx], atol=0.025)

idx = np.where(azimuth_1 > 0.3)
assert np.allclose(azimuth_1[idx], solar_azimuth.as_matrix()[idx],
atol=0.025)
for idx, azi in enumerate(azimuth_1):
if azi < 0.3:
assert np.isclose(azi, solar_azimuth[idx], atol=0.025) or \
np.isclose(azi + np.pi * 2, solar_azimuth[idx], atol=0.55)

idx = np.where(azimuth_2 > 0.3)
assert np.allclose(azimuth_1[idx], solar_azimuth.as_matrix()[idx],
atol=0.025)
for idx, azi in enumerate(azimuth_2):
if azi < 0.3:
assert np.isclose(azi, solar_azimuth[idx], atol=0.025) or \
np.isclose(azi + np.pi * 2, solar_azimuth[idx], atol=0.55)