Skip to content

Conversation

@cwhanse
Copy link
Member

@cwhanse cwhanse commented Oct 20, 2025

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Corrects a test fixture used for the adr inverter model. The cec_dc_adr_ac_system fixture had a single 220W module paired with a 3kW inverter. The adr function returned nan for some valid input, due to unreasonably low DC:AC ratio.

@cwhanse
Copy link
Member Author

cwhanse commented Oct 20, 2025

For details, see this comment

Why is a NaN also in the first line, where the DC values look reasonable? Because the test system is malformed. The test system pairs a single 220W module with a 3kW inverter.

@kandersolar kandersolar added this to the v0.13.2 milestone Oct 28, 2025
@kandersolar kandersolar merged commit 6553710 into pvlib:main Oct 28, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants