Skip to content

Fix meteonorm tests for older pandas versions #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix meteonorm tests for older pandas versions #2553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc6442
allow ValueError for older pandas versions
kandersolar Sep 24, 2025
8af26c3
add explanatory comment
kandersolar Sep 24, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pvlib/iotools/meteonorm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,19 +532,21 @@ def _get_meteonorm(

# Check for None type in case of TMY request
# Check for DateParseError in case of relative times, e.g., '+3hours'
# TODO: remove ValueError when our minimum pandas version is high enough
# to make it unnecessary (2.0?)
if (start is not None) & (start != 'now'):
try:
start = pd.Timestamp(start)
start = start.tz_localize("UTC") if start.tzinfo is None else start
start = start.strftime("%Y-%m-%dT%H:%M:%SZ")
except DateParseError:
except (ValueError, DateParseError):
pass
if (end is not None) & (end != 'now'):
try:
end = pd.Timestamp(end)
end = end.tz_localize("UTC") if end.tzinfo is None else end
end = end.strftime("%Y-%m-%dT%H:%M:%SZ")
except DateParseError:
except (ValueError, DateParseError):
pass

params = {
Expand Down
Loading