Skip to content

Conversation

@mikofski
Copy link
Member

@mikofski mikofski commented Oct 6, 2024

update link to contributing from readme

  • Closes Contributing link on Readme is broken #2239
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.
Close #2239 update link to contributing from readme
@mikofski mikofski merged commit cbe4cc5 into main Oct 6, 2024
29 checks passed
@mikofski mikofski deleted the Fix-contributing-link branch October 6, 2024 07:06
@echedey-ls
Copy link
Contributor

That was fast! Let's not forget to include matsuobasho in the contributors list in the release PR.

@kandersolar kandersolar added this to the v0.11.2 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment