add spectrum.average_photon_energy gallery example #2206
Conversation
| For everyone else stalking Dax progress with each commit: https://pvlib-python--2206.org.readthedocs.build/en/2206/gallery/spectrum/average_photon_energy.html#sphx-glr-gallery-spectrum-average-photon-energy-py |
add interpretation of APE values underneath table
add ape table
add last accessed to references
wording, remove table
reference order
| Tentatively marking this ready for review. Would be good to get some feedback at this stage. |
RDaxini changed the title spectrum.average_photon_energy gallery examplespectrum.average_photon_energy gallery example 
IoannisSifnaios left a comment
IoannisSifnaios left a comment There was a problem hiding this comment.
Looks good @RDaxini! Some minor edits and ideas from my side.
Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com>
| Thanks for the review @IoannisSifnaios |
kandersolar left a comment
kandersolar left a comment There was a problem hiding this comment.
I like it. It's a bit lengthy for a gallery example, but until we have a better place for long-form tutorial content, I think this is fine.
A few suggestions below.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
add = variable names remove unused package
gallery example ref
| I have resolved all outstanding issues. Let me know if there's anything else
^hmm I had been thinking along similar lines |
echedey-ls left a comment
echedey-ls left a comment There was a problem hiding this comment.
LGTM too.
Minor visualization suggestions down below; they ain't blockers.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
update legend Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
| @echedey-ls @kandersolar see the last commit, does that look better? Let me know what you think. Happy to revise further if necessary. I appreciate the review/suggestions |
| Yeah! It super good. |
| Thanks @RDaxini :) |
4 participants
spectrum.average_photon_energy#2194docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This example demonstrates the use of
spectrum.average_photon_energywith the output ofspectrum.spectrl2as an input.Link to example here