Skip to content

Conversation

@mikofski
Copy link
Member

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.
@mikofski
Copy link
Member Author

Does this really need a comment in what's new? I say go ahead and merge. What do others think?

@wholmgren wholmgren merged commit aba071f into pvlib:master Nov 15, 2021
@mikofski mikofski deleted the docs-license-link-broken branch December 18, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment