Skip to content

Conversation

kl0tl
Copy link
Member

@kl0tl kl0tl commented Oct 24, 2020

This became possible with #121.

maximum :: forall f a. Ord a => Foldable1 f => f a -> a
maximum = ala Max foldMap1

maximumBy :: forall f a. Ord a => Foldable1 f => (a -> a -> Ordering) -> f a -> a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ord constraint is redundant here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove to remove the constraint after copying Data.Foldable.maximumBy and Data.Foldable.minimumBy 🤦

@thomashoneyman thomashoneyman merged commit 8413e6d into purescript:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants