Add missing statuses to FilterHeadersStatus. #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows WASM proxies to return any of the statuses supported by native Envoy filters. Signed-off-by: Gregory Brail <gregbrail@google.com>
gbrail added a commit to gbrail/envoy-wasm that referenced this pull request May 18, 2020
This requires the changes made to proxy-wasm-cpp-sdk in proxy-wasm/proxy-wasm-cpp-sdk#19. With this change, a WASM filter can return, say, StopAllIterationAndWatermark. This is useful when a WASM filter might want to call an external service and use the result to change an HTTP header before continuing processing the body. Signed-off-by: Gregory Brail <gregbrail@google.com>
jplevyak approved these changes May 19, 2020
gbrail added a commit to gbrail/envoy-wasm that referenced this pull request May 20, 2020
This requires the changes made to proxy-wasm-cpp-sdk in proxy-wasm/proxy-wasm-cpp-sdk#19. With this change, a WASM filter can return, say, StopAllIterationAndWatermark. This is useful when a WASM filter might want to call an external service and use the result to change an HTTP header before continuing processing the body. Signed-off-by: Gregory Brail <gregbrail@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows WASM proxies to return any of the statuses supported
by native Envoy filters.
Note that this change will break Envoy until two other PRs are committed to the two other repos -- these are coming soon.
Signed-off-by: Gregory Brail gregbrail@google.com