Skip to content

Conversation

@martijneken
Copy link
Contributor

@martijneken martijneken commented Oct 10, 2024

Fixes #175

Related cleanups:

  • Simpler Docker container
  • Single Makefile
  • Support for -flto
  • Proto upgrade to v26.1
  • Updated build docs
  • More/independent examples
  • Remove protobuf CI check

Notes

  • Depends on Emscripten update in Fix SDK Docker build scripts, update Emscripten #172.
  • Found that absl::random doesn't work yet, will send a follow-up patch to implement getentropy
  • Deferring Bazel protobuf update, since this requires Bazel toolchain updates (FWIW Bazel/Make protobuf versions are already out of sync)
Depends on Emscripten update in proxy-wasm#172. Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
- Simpler Docker container - Single Makefile - Support for -flto - Proto upgrade to v26.1 - Updated build docs Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken changed the title Fix Abseil + RE2 support Full Abseil + RE2 support Oct 19, 2024
- add license headers to generated files - update Bazel builds for examples - remove unnecessary protobuf binary CI check Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken marked this pull request as ready for review October 19, 2024 05:23
@martijneken martijneken requested a review from leonm1 October 21, 2024 14:09
Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken merged commit 9dc95ae into proxy-wasm:main Oct 25, 2024
4 checks passed
@martijneken martijneken deleted the abseil-re2-fix branch October 25, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants