Skip to content

Conversation

@iliax
Copy link
Contributor

@iliax iliax commented Jul 28, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  1. EnhancedConsumer created to gather all poll-related operations
  2. ApplicationMetrics created as a central app metrics place

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner July 28, 2023 12:51
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jul 28, 2023
@iliax iliax enabled auto-merge (squash) July 28, 2023 13:15
@iliax iliax changed the title ISSSUE4052: Polling metrics ISSSUE-4052: Polling metrics Aug 1, 2023
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend and removed status/triage Issues pending maintainers triage labels Aug 1, 2023
@Haarolean Haarolean linked an issue Aug 1, 2023 that may be closed by this pull request
2 tasks
@Haarolean Haarolean added type/feature A new feature and removed type/enhancement En enhancement to an already existing feature labels Aug 1, 2023
@iliax iliax merged commit c96a0c6 into master Aug 1, 2023
@iliax iliax deleted the ISSUE-4052_app_metrics branch August 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants