Skip to content

Conversation

@Haarolean
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #3883

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend status/image_testing labels May 30, 2023
@Haarolean Haarolean requested a review from a team as a code owner May 30, 2023 14:04
@Haarolean Haarolean self-assigned this May 30, 2023
@github-actions
Copy link

Image published at public.ecr.aws/provectus/kafka-ui-custom-build:3884

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Image tag public.ecr.aws/provectus/kafka-ui-custom-build:3884 has been removed

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Image published at public.ecr.aws/provectus/kafka-ui-custom-build:3884

@0x4ec7
Copy link

0x4ec7 commented Jun 9, 2023

This parameter is pretty much needed, and a more generic default value should be used, eg, (|(member={0})(uniqueMember={0})).

@iliax iliax self-requested a review June 26, 2023 08:30
@Haarolean Haarolean changed the title RBAC: LDAP: Support group search filter filter alongside with base RBAC: LDAP: Support group search filter filter and subtree search Jun 26, 2023
@Haarolean Haarolean enabled auto-merge (squash) June 26, 2023 09:13
@Haarolean Haarolean disabled auto-merge June 26, 2023 09:17
@Haarolean
Copy link
Contributor Author

Superseded by #3979

@Haarolean Haarolean closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend type/enhancement En enhancement to an already existing feature

3 participants