[WIP] added type annotations. #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathanslenders force-pushed the type-annotations branch 3 times, most recently from c217827 to a868756 Compare jonathanslenders force-pushed the type-annotations branch 16 times, most recently from 50bfc66 to 9d0740f Compare jonathanslenders force-pushed the type-annotations branch 10 times, most recently from 2a1e146 to 305527f Compare jonathanslenders force-pushed the type-annotations branch 17 times, most recently from 3b447de to 36bc9c8 Compare 
This is a rewrite that starts taking advantage of Python 3 functionality. - It uses native asyncio coroutines and async generators everywhere. - We have type annotations in most of the code. - Python 2 support has been dropped (usage of six has been removed). - Use of ContextVars for keeping track of the currently running application.
jonathanslenders force-pushed the type-annotations branch from 36bc9c8 to c7851c0 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For prompt_toolkit 3.0, we'd like at least the following:
This pull request adds type annotations (still work in progress).