Skip to content

Conversation

@randy3k
Copy link
Contributor

@randy3k randy3k commented Apr 21, 2018

a continuation of #611

@randy3k randy3k changed the title need to refresh ui after reset completion state need to refresh ui after resetting completion state Apr 21, 2018
@codecov-io
Copy link

codecov-io commented Apr 21, 2018

Codecov Report

Merging #612 into 2.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## 2.0 #612 +/- ## ========================================== + Coverage 70.93% 70.93% +<.01%  ========================================== Files 132 132 Lines 12152 12153 +1 ========================================== + Hits 8620 8621 +1  Misses 3532 3532
Impacted Files Coverage Δ
prompt_toolkit/buffer.py 67.83% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdec6e...a832257. Read the comment docs.

@jonathanslenders
Copy link
Member

Hi @randy3k,

Can you tell me what goes wrong without this change? Why it is needed.
I would probably like to add one or two lines documentation.

Thanks!
Jonathan

@randy3k
Copy link
Contributor Author

randy3k commented Apr 27, 2018

If there was only one completion item and this line deleted it. The completion menu was displayed, but the complete_state was set to None . We end up with the menu popping up but the state is empty.

PS: I added two lines of comment.

@jonathanslenders
Copy link
Member

Perfect! Thanks a lot @randy3k!

@jonathanslenders jonathanslenders merged commit 0b450e6 into prompt-toolkit:2.0 May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants