Skip to content

history search if line contains or starts with string #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

history search if line contains or starts with string #534

wants to merge 2 commits into from

Conversation

@ahundt
Copy link

@ahundt ahundt commented Aug 13, 2017

(#532)
@ahundt
Copy link
Author

ahundt commented Aug 13, 2017

Those filter classes like SimpleFilter seems to only support true and false options or I'd have used it. Hopefully my approach is reasonable but I'm open to make changes.
@ahundt ahundt mentioned this pull request Aug 13, 2017
Closed
@jonathanslenders
Copy link
Member

Hi @ahundt,

Thanks a lot for this pull request.
The 1.0 branch is actually bugfix only, but I'd like to merge this in the 2.0 branch once I've had the time to review it.

It's very useful.
@ahundt
Copy link
Author

ahundt commented Aug 17, 2017

cool, thanks!
@ahundt
Copy link
Author

ahundt commented Aug 21, 2017

@jonathanslenders I've been using the existing functionality a bit more and I realized along with this change I'd also love for the selection of completion to be case-insensitive. In other words if there is a LICENSE.txt in a folder and you type lic<tab>, LICENSE.txt would be an option. I believe that would also be a very small change much like this one.
@decentral1se decentral1se mentioned this pull request Jul 10, 2018
Open
@anki-code
Copy link

@jonathanslenders this looks like merged and should be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ahundt @jonathanslenders @anki-code