Fix vt100 colors #418
Closed
Fix vt100 colors #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
melund force-pushed the fix_vt100_colors branch from b6d7797 to 0b0004f Compare 
| I just rebased. |
| Thanks! So, this switches actually light gray and dark gray. Right? |
| Well yes. But I think this was something I messed up in #408 |
| Merged in: 2eadc7e Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I found a way to run xonsh/PTK with the VT100 backend on Windows. Works great, and super fast. But I just realized that the mapping from ansi color names to vt100 codes is completely messed up. Partly my own fault in #408, but I didn't have a way to test it then.
I do now. So here is a fix and sorry for the trouble.