Avoid extra vertical scrolling on windows if the cursor is already on screen #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
win32_output.scroll_buffer_to_prompt()tries to scroll the cursor onto the screen with a preference to place the cursor at the bottom if the buffer is larger than the view-port. This does not take in to account that the cursor may already be in the view-port. If the cursor is in the view-port, it is moved to the bottom, and then very shortly there after moved up 8 lines to account for the reserved area for the menu. Using https://github.com/click-contrib/click-repl this causes the screen to flicker anytime the screen is scrolled.This PR leaves the vertical scroll unchanged if the cursor is already in the view-port.