Try to run ruff and typo only on 3.13 #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There is no need to run N times. This in particular means that we can still see from a glace the tests are passing on older python. I also try to run typo regardless of wether ruff check and formating passes, which hopefully avoid one iteration of fix, push and CI failing.
| I'm not the best at GitHub action syntax though. |
| Thanks! |
| I think something went wrong here. GitHub actions is no longer running since I merged this. |
| Fixed here: #1965 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There is no need to run N times.
This in particular means that we can still see from a glance the tests are passing on older python.
I also try to run typo regardless of wether ruff check and formatting passes, which hopefully avoid one iteration of fix, push and CI failing.