Telnet fixes #1586
Merged
Telnet fixes #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathanslenders force-pushed the telnet-fixes branch 2 times, most recently from b9e2be6 to 0f8a18c Compare jonathanslenders force-pushed the telnet-fixes branch 3 times, most recently from 76ffbdb to 3cdcf3f Compare This makes context managers of the following: - `create_pipe_input()` - `PosixPipeInput` - `Win32PipeInput` The reason for this change is that the close method of the pipe should only close the write-end, and as a consequence of that, the read-end should trigger an `EOFError`. Before this change, the read-end was also closed, and that caused the key input to never wake up and "read" the end-of-file. However, we still want to close the read end at some point, and that's why this is a context manager now. As part of this change, exceptions that are raised in the TelnetServer interact method, won't cause cause the whole server to crash. See also: #1585 Co-Author: Frank Wu <kwyd@163.com>
jonathanslenders force-pushed the telnet-fixes branch from 3cdcf3f to 071c2cd Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.