Skip to content

Deterministic minimun size for completion menu, even at bottom of screen (for PromptSession) #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Deterministic minimun size for completion menu, even at bottom of screen (for PromptSession) #1259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2589ddf
First hack: ad-hoc calculate height of completion menus.
Sep 28, 2020
bba8417
floats_min_preferred_height for FloatContainer
Sep 28, 2020
5edd721
Turn off completions 'show-meta' to get configured number
Sep 28, 2020
283d010
Allows MultiLineCompletionMenu to hide meta display line
Sep 29, 2020
cd24b72
Tighten up floats_min_preferred_height
Sep 29, 2020
cca2a19
Right prompt doesn't drop to bottom of screen;
Sep 29, 2020
1bf9ce1
fixup CI failures; rprompt doesn't change in prompt, don't need Condi…
Sep 29, 2020
9184423
Fix CI failures
Sep 29, 2020
c53c62c
Fix extra blank line when right prompt displayed.
Oct 2, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix extra blank line when right prompt displayed.
  • Loading branch information
Bob Hyman committed Oct 2, 2020
commit c53c62c760fe1d04cbdf661cdad47666ce892a91
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,6 @@ docs/_build

# vscode settings
.vscode/

# virtual environment
.venv/
2 changes: 1 addition & 1 deletion prompt_toolkit/layout/containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ def preferred_height(self, width: int, max_available_height: int) -> Dimension:
),
self.floats_min_preferred_height() or 0,
)
ph.preferred += floats_ph
ph.preferred = max(ph.preferred, floats_ph)
return ph

def write_to_screen(
Expand Down
2 changes: 1 addition & 1 deletion prompt_toolkit/shortcuts/prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ def get_reserve_space_for_menu() -> int:
),
right=0,
top=0, # right prompt floats to *top* of prompt.
hide_when_covering_content=True,
hide_when_covering_content=False, # and should overright main prompt when so.
),
],
floats_min_preferred_height=get_reserve_space_for_menu,
Expand Down