ProgressBar Conditional remove_when_done #1042
   Open  
   Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Inspired by the discussion in #1025 (comment).
Instead of using a threaded approach for
remove_when_doneprocessing we check for removals as part of the rendering process instead.@jonathanslenders this feels like a hack at this point, not sure if we'd want the
get_progress_bar/set_progress_bar/get_counter/set_counterto be extending theAppSessionor whether using this separateProgressBarSessionis preferred.If we continue down this contexvar path then maybe
AppSessionshould be made more generic to where anything can be set in a session? So we'd introduce something likeget_contextvar(key)andset_contextvar(key, value). Just thinking out loud here.