Feature/telnet #103
Merged
Feature/telnet #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathanslenders force-pushed the feature/telnet branch 13 times, most recently from 0992460 to 1129746 Compare 
…loop and Renderer.) - Renderer now accepts an Output object instead of stdout. - CommandLineInterface now accepts an optional Output argument, which will be passed to the renderer. (Normally the default is okay.) - CommandLineInterface now accepts an AcceptAction argument for defining the behaviour of "accept" (Either return document or call handler.) - Property "is_reading_input" of CommandLineInterface has been removed. (Not required and meaning was unclear in some situations.) - CommandLineInterface.run_in_executor and CommandLineInterface.call_from_executor have been removed. (Call run_in_executor/call_from_executor on CommandLineInterface.eventloop instead.) - on_abort and on_exit have been moved from CommandLineInterface.read_input to CommandLineInterface.__init__, because its behaviour has more to do with key binding actions than reading input. - More refactoring of the CommandLineInterface and Renderer classes. - Eventloop._reset became public.
jonathanslenders force-pushed the feature/telnet branch from 1129746 to 447f1e2 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Experimental telnet implementation + many refactorings.
Please don't merge yet. Should remove the readline_compat commit first. (That one is not yet finished.)