Introducing ProgressBarCounter.stopped #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This makes sense, I've added a few remarks. Thanks a lot for this! And thanks for your patience, it's been very busy here... |
kenodegard force-pushed the progressbar.stop branch from e4ff1b5 to ed143e9 Compare 
kenodegard commented Dec 20, 2019
| yield item | ||
| self.item_completed() | ||
| | ||
| # Only done if we iterate to the very end. |
There was a problem hiding this comment.
should we intercept any exceptions here and set stopped?
kenodegard changed the title Include a distinction for counters that have stopped (time_elapsed no longer increments and Bar formatter stops running in the case of unknown totals). This allows bars to better handle cases where a counter doesn't complete properly and terminates in some error state the developer cares about. Added breaking task to a-lot-of-parallel-tasks.py example.
kenodegard force-pushed the progressbar.stop branch from ed143e9 to b2368ba Compare 
| I'm merging this. It looks good. We can still improve/fix in other PRs. Wouldn't it make sense to set the ETA to 0 when stopped=True? This confused me in the example. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Include a distinction for counters that have stopped (time_elapsed no longer increments and Bar formatter stops running in the case of unknown totals). This allows bars to better handle cases where a counter doesn't complete properly and terminates in some error state the developer cares about.
@jonathanslenders I think this is one of the last ProgressBar ideas I have.