Skip to content

Conversation

@guidoiaquinti
Copy link
Contributor

After reviewing the collectors code I think we can reduce the scope of the MySQL grants to strictly mentions what it needs to run.

I'm not sure we really need

GRANT SELECT ON `information_schema`.* TO 'exporter'@'localhost';

as for InnoDB tables it should be indirectly granted by the PROCESS privilege (at least on MySQL 5.7+).

README.md Outdated

[pth]:https://www.percona.com/doc/percona-toolkit/2.2/pt-heartbeat.html

Please remind to add the following grant:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "You will need to grant the exporter access to the heartbeat table:"

@brian-brazil
Copy link
Contributor

brian-brazil commented Oct 31, 2017

I have a vague recollection that SELECT was required on *.* for some of the performance schema to work. Is that no longer the case?

@brian-brazil
Copy link
Contributor

I don't mean that the query reference it directly, I meant that there was additional access control under the covers in MySQLd that required a broad SELECT.

@guidoiaquinti
Copy link
Contributor Author

👍 got it. Unfortunately without integration tests running for all the supported MySQL versions I'm not sure how we can verify it.

@brian-brazil
Copy link
Contributor

Ah, #153

@SuperQ
Copy link
Member

SuperQ commented Oct 31, 2017

@brian-brazil Yea, that's the one. We still support MySQL 5.1, and *.* is required for those versions.

@SuperQ
Copy link
Member

SuperQ commented Jan 13, 2018

Since this won't work on older versions, I think we have to close this for now.

@SuperQ SuperQ closed this Jan 13, 2018
@grafra grafra mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants