Modified required grants in README.md #242
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After reviewing the collectors code I think we can reduce the scope of the MySQL grants to strictly mentions what it needs to run.
I'm not sure we really need
GRANT SELECT ON `information_schema`.* TO 'exporter'@'localhost';as for InnoDB tables it should be indirectly granted by the
PROCESSprivilege (at least on MySQL 5.7+).