Handle / in job name in Prometheus::Client::Push #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dmagliola approved these changes Aug 3, 2023
This a subtlety I missed when overhauling the Pushgateway client. While the job name can't be empty like other grouping key labels can, it can contain `/`, which means we need to base64 encode the value in that case. Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Sinjo force-pushed the sinjo-base64-job-push branch from 3c9f197 to 6f7b6cf Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This a subtlety I missed when overhauling the Pushgateway client.
While the job name can't be empty like other grouping key labels can, it can contain
/, which means we need to base64 encode the value in that case.