Add Gauge#set_to_current_time #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I was porting some code from Python to Ruby today, and when I went to call this method, I realised we don't have it! My use-case is to track the last time some code successfully ran. I'm open to discussing the naming, but I've defaulted to the name used in `client_python` because it seems good to me. Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
electron0zero approved these changes Jun 12, 2023
Member
| I think we are missing it in client_ruby, and should add it, guide on writing client says Guage SHOULD have this method:
source: https://prometheus.io/docs/instrumenting/writing_clientlibs/#gauge |
Member Author
| Perfect. Let's do this! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was porting some code from Python to Ruby today, and when I went to call this method, I realised we don't have it!
My use-case is to track the last time some code successfully ran.
I'm open to discussing the naming, but I've defaulted to the name used in
client_pythonbecause it seems good to me.Fixes #51 (I think?)