Skip to content

Conversation

kishan-23
Copy link
Contributor

This was creating python version issues during installation. usr/bin/python points to a different version of python, than used in virtual env. Somehow, due to restrictions, can't change usr/bin/python. So changed to #!/usr/bin/env python. Already have a PR merged for this issue.

Kishan Verma added 3 commits June 25, 2023 21:26
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
@roidelapluie
Copy link
Member

Is this up to date and has actual test failure or does it need a rebase for tests to pass?

Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is due to not being up to date with a fix to the tests. Merging anyway.

@csmarchbanks csmarchbanks merged commit 34553ad into prometheus:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants