Optimize parser #1117
Merged
Optimize parser #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks force-pushed the optimize-parser branch from d4b9fe2 to e1f8c69 Compare This saves ~10% in the benchmark. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
Enumerating rather than using a while loop saves significant CPU when looking for an unquoted character. This ends up improving the benchmark ~20% on its own. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
Split the term into the label name and label value portions in one swoop rather than starting from the beginning to find an = character after already going through the full term. This saves ~5% on the benchmark. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks force-pushed the optimize-parser branch from e1f8c69 to 2a2ca52 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Several commits that help alleviate the CPU increase reported in #1114. The performance is still worse than 0.22.1 but moving in the correct direction, and I don't know if we will be able to match performance with the additional features.
For reference, here are the benchmark results from my laptop. We still have a ways to go to get back to original peformance.