Skip to content

Fix: handle nil variableLabels in Desc.String() method and add tests for nil label values #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix: handle nil variableLabels in Desc.String() method and add tests for nil label values #1687

merged 1 commit into from
Nov 25, 2024

Conversation

kakkoyun
Copy link
Member

Fixes #1684

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
@kakkoyun kakkoyun requested a review from vesari November 19, 2024 16:02
@kakkoyun
Fix: handle nil variableLabels in Desc.String() method and add tests …
7b0b4c3 
…for nil label values Fixes #1684 Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka
bwplotka approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@bwplotka bwplotka merged commit 1880f1b into main Nov 25, 2024
12 checks passed
@bwplotka bwplotka deleted the fix_1684 branch November 25, 2024 10:13
amberpixels pushed a commit to amberpixels/prometheus_client_golang that referenced this pull request Nov 29, 2024
@kakkoyun @amberpixels
Fix: handle nil variableLabels in Desc.String() method and add tests …
ff4f508 
…for nil label values (prometheus#1687) Fixes prometheus#1684 Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Eugene <eugene@amberpixels.io>
This was referenced Feb 19, 2025
Merged
Merged
@dghubble-renovate dghubble-renovate bot mentioned this pull request Feb 19, 2025
Merged
1 task
@mr-borboto mr-borboto bot mentioned this pull request Feb 19, 2025
Merged
1 task
@pull-bunyan pull-bunyan bot mentioned this pull request Feb 19, 2025
Closed
1 task
@pb-renovate pb-renovate bot mentioned this pull request Feb 19, 2025
Closed
1 task
@theriver-bot theriver-bot bot mentioned this pull request Feb 19, 2025
Merged
1 task
@larsl-renovate larsl-renovate bot mentioned this pull request Feb 19, 2025
Merged
1 task
@cilium-renovate cilium-renovate bot mentioned this pull request Feb 17, 2025
Merged
1 task
This was referenced Feb 19, 2025
Merged
Merged
Merged
Merged
@rwunderer rwunderer mentioned this pull request Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Open
Closed
Open
Closed
Closed
Closed
Closed
Open
Merged
@red-hat-konflux red-hat-konflux bot mentioned this pull request Aug 20, 2025
Closed
1 task
This was referenced Aug 24, 2025
Merged
Merged
@wall-e1-bot wall-e1-bot bot mentioned this pull request Aug 26, 2025
Merged
1 task
This was referenced Aug 29, 2025
Merged
Merged
Merged
Closed
Open
Open
Open
@renovate renovate bot mentioned this pull request Sep 7, 2025
Open
1 task
@red-hat-konflux red-hat-konflux bot mentioned this pull request Sep 7, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 7, 2025
Merged
1 task
@NetcrackerCLPLCI NetcrackerCLPLCI mentioned this pull request Sep 9, 2025
Closed
1 task
This was referenced Sep 18, 2025
Merged
Open
Closed
@red-hat-konflux red-hat-konflux bot mentioned this pull request Sep 21, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 22, 2025
Open
1 task
@konflux-internal-p02 konflux-internal-p02 bot mentioned this pull request Sep 25, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Sep 25, 2025
Merged
1 task
This was referenced Sep 26, 2025
Open
Open
Closed
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Oct 8, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kakkoyun @bwplotka