Skip to content

Conversation

imorph
Copy link
Contributor

@imorph imorph commented Nov 4, 2024

This changes were supposed to be merged in #1662 but after some git manipulations it closed itself.
Here clean version of it.

Signed-off-by: Ivan Goncharov <i.morph@gmail.com>
@imorph imorph mentioned this pull request Nov 4, 2024
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

I'll wait a couple of days in case another maintainer wants to take a look before merging

@ArthurSens ArthurSens merged commit 2b11a4b into prometheus:main Nov 8, 2024
10 checks passed
dhartunian pushed a commit to cockroachdb/client_golang that referenced this pull request Jan 24, 2025
Original PR: prometheus#1673 Which was discussed in more detail in a prior iteration here: prometheus#1662 Signed-off-by: Ivan Goncharov <i.morph@gmail.com>
@renovate renovate bot mentioned this pull request Oct 8, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants