Optionally print OM created lines #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ArthurSens changed the title 
bwplotka reviewed Dec 22, 2023
ArthurSens force-pushed the om-created-lines branch from c26d312 to b7d00b2 Compare ArthurSens changed the title ArthurSens force-pushed the om-created-lines branch 3 times, most recently from e930252 to 240345e Compare bwplotka approved these changes Feb 5, 2024
ArthurSens force-pushed the om-created-lines branch 2 times, most recently from 33ed3e6 to e9c6f77 Compare bwplotka approved these changes Mar 25, 2024
ArthurSens force-pushed the om-created-lines branch from e9c6f77 to 81909c5 Compare 
| We need prometheus/common v0.49.0 for this feature, but this version of prometheus/common requires go 1.21. Therefore, the PR is blocked until we drop support for go 1.20 |
ArthurSens force-pushed the om-created-lines branch from 81909c5 to 65df2d7 Compare | After quite some work to unblock this, this is finally ready :) Do you want to review again or should I just merge? |
| Now that prometheus/prometheus#14356 was merged, should we revive this? :) |
ArthurSens force-pushed the om-created-lines branch 2 times, most recently from eb0f4ef to b51b530 Compare | Since we have approvals from the past, I'll take the liberty to merge this PR next week :) |
bwplotka requested changes Sep 18, 2024
Closed
1 task
This was referenced Aug 24, 2025
This was referenced Aug 29, 2025
Merged
Merged
1 task
1 task
1 task
This was referenced Sep 18, 2025
1 task
1 task
1 task
Merged
1 task
This was referenced Sep 26, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds an extra option to print _created lines when OpenMetrics is the chosen exposition format. It's implemented following the conditional option added in prometheus/common#504.