Skip to content

Add a collector to gather metrics on WAL size #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

Add a collector to gather metrics on WAL size #858

merged 2 commits into from
Jul 5, 2023

Conversation

tomhughes
Copy link
Contributor

No description provided.

@tomhughes
Add some more escapes to the query sanitizer
099d3dd 
Signed-off-by: Tom Hughes <tom@compton.nu>
SuperQ
SuperQ requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor nit, otherwise LGTM
@tomhughes
Add a collector to gather metrics on WAL size
2ca1798 
Signed-off-by: Tom Hughes <tom@compton.nu>
@SuperQ SuperQ requested a review from sysadmind July 5, 2023 12:10
sysadmind
sysadmind approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sysadmind sysadmind merged commit cf67a47 into prometheus-community:master Jul 5, 2023
@tomhughes tomhughes deleted the wal branch July 5, 2023 13:06
@jouve jouve mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@tomhughes @SuperQ @sysadmind