Skip to content

Bug fix: Make collector not fail on null values #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Bug fix: Make collector not fail on null values #823

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
938af74
Make all values nullable
Sticksman Jun 24, 2023
b4986f9
Lint
Sticksman Jun 24, 2023
2e267b0
Lint
Sticksman Jun 24, 2023
d692c95
Update collector/pg_process_idle.go
Sticksman Jun 25, 2023
43e0475
Update collector/pg_postmaster.go
Sticksman Jun 25, 2023
cec3fb5
Update collector/pg_database.go
Sticksman Jun 25, 2023
19cf776
Be more go-like
Sticksman Jun 25, 2023
5f1382c
Add a row leak test
Sticksman Jun 25, 2023
0c05f83
Drop the declaration because it's considered the "0" values
Sticksman Jun 25, 2023
1ec3a9a
Typo
Sticksman Jun 26, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Typo 
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
  • Loading branch information
@Sticksman
Sticksman committed Jun 26, 2023
commit 1ec3a9ab24ddd9afd78d5afeffba65fd5a5b9f5c
2 changes: 1 addition & 1 deletion collector/pg_process_idle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (

func init() {
// Making this default disabled because we have no tests for it
registerCollector("statements", defaultDisabled, NewPGProcessIdleCollector)
registerCollector(processIdleSubsystem, defaultDisabled, NewPGProcessIdleCollector)
}

type PGProcessIdleCollector struct {
Expand Down