Fix replication_slot query all supported versions #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @halvaborsch can you please fix DCO. Really looking forward to this MR |
Signed-off-by: Филатов Дмитрий <d.filatov@2gis.ru>
halvaborsch force-pushed the halvaborsch-replication-slot-patch-1 branch from f3eef51 to 29f6fa1 Compare | @hd-deman sure sry |
| @SuperQ can you review pls 🙏 |
| Any news on this? |
| Great! When can we expect a new tag? |
| Nice! Is there any release date for this fix? |
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
…sch-replication-slot-patch-1 Fix replication_slot query all supported versions
| is there already a release including this tag? I found it. Thanks https://github.com/prometheus-community/postgres_exporter/releases/tag/v0.10.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The right way to fix #495
Lets not forget about older postgres version.