Update readme file #530
Closed
Update readme file #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* fix missing cross-platform build destination * suggest cloning into GOPATH/src directory structure * beautify formatting Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
SuperQ reviewed May 10, 2021
README.md Outdated
| make build | ||
| ./postgres_exporter <flags> | ||
| $ mkdir -p $GOPATH/src/github.com/prometheus-community | ||
| $ cd $GOPATH/src/github.com/prometheus-community |
There was a problem hiding this comment.
This is not necessary anymore, and not recommended. The GOPATH style is officially deprecated (Go 1.13).
README.md Outdated
| make promu | ||
| promu crossbuild -p linux/amd64 -p linux/armv7 -p linux/amd64 -p linux/ppc64le | ||
| make docker | ||
| $ make promu |
There was a problem hiding this comment.
I'm not sure I like adding command prompts to this. I find it easier to copy-n-paste lines without them.
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
| thanks @SuperQ , this is ready for another look, the only change is fixing a typo in build destination |
| This was fixed in: #903 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Wasilewski mwasilewski@gmx.com