Skip to content

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Feb 19, 2021

Add standard Prometheus build setup

  • CircleCI config
  • Makefile
  • Go modules
  • Golang-CI Lint
  • promu config
  • Remove /vendor
  • Remove mage build
  • Update READMEs

#478

Fixes: #470

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ SuperQ requested a review from wrouesnel February 19, 2021 10:04
@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 19, 2021

After this is done, we can work on re-adding integration tests. We do similar things in the mysqld_exporter CircleCI config.

@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 22, 2021

Ping @wrouesnel

@roidelapluie
Copy link

Can you please give a second pass at the README ? still mentions vendoring and mage.

Add standard Prometheus build setup * CircleCI config * Makefile * Go modules * Golang-CI Lint * promu config * Remove /vendor * Remove mage build * Update READMEs #478 Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 23, 2021

Ok, I updated the README some more.

@SuperQ SuperQ requested a review from roidelapluie February 23, 2021 11:40
Copy link

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even think that we need to mention vendoring at all but LGTM.

@SuperQ SuperQ merged commit c1ddbee into master Feb 26, 2021
@SuperQ SuperQ deleted the superq/community branch February 26, 2021 13:59
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
…/superq/community Update for Prometheus Community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants