Skip to content

Add a build info metric #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2019
Merged

Add a build info metric #323

merged 4 commits into from
Nov 25, 2019

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 1, 2019

Add a standard Prometheus build info metric to make monitoring rollouts
easier.
@coveralls
Copy link

coveralls commented Nov 1, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 64.7% when pulling 934592d on SuperQ:version_metric into 03013de on wrouesnel:master.
@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 1, 2019

I'm not sure the best way to add test coverage for the additional code.
@wrouesnel
Copy link
Contributor

I'm content with the test coverage, but could you rebase the vendoring changes into one commit?
@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 20, 2019

Sure, no problem
@SuperQ SuperQ force-pushed the version_metric branch 2 times, most recently from 90782ff to 547f01c Compare November 20, 2019 01:37
@SuperQ
Copy link
Contributor Author

SuperQ commented Nov 20, 2019 •
edited
Loading

Fast-forward rebased and squashed the vendor change.
@SuperQ
Fix build error
011cb70 
Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ
Add a build info metric
46beee2 
Add a standard Prometheus build info metric to make monitoring rollouts easier.
@SuperQ
Update prometheus vendoring.
3c1810f
@wrouesnel wrouesnel merged commit aeec47e into prometheus-community:master Nov 25, 2019
english pushed a commit to form3tech-oss/postgres_exporter that referenced this pull request Jan 31, 2020
@SuperQ
Add a build info metric (prometheus-community#323)
26f3cf5 
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <superq@gmail.com> (cherry picked from commit aeec47e)
english pushed a commit to form3tech-oss/postgres_exporter that referenced this pull request Jan 31, 2020
@SuperQ
Add a build info metric (prometheus-community#323)
e1d8378 
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <superq@gmail.com> (cherry picked from commit aeec47e)
ritbl referenced this pull request in heniek/postgres_exporter Mar 19, 2023
@SuperQ @wrouesnel
Add a build info metric (percona#323)
91612bd 
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <superq@gmail.com>
alessio-form3 pushed a commit to form3tech-oss/postgres_exporter that referenced this pull request Oct 10, 2023
@SuperQ @alessio-form3
Add a build info metric (prometheus-community#323)
28e504f 
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <superq@gmail.com> (cherry picked from commit aeec47e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@SuperQ @coveralls @wrouesnel