Skip to content

Connections to the database remains open for each database when you use PG_EXPORTER_AUTO_DISCOVER_DATABASES #436

Open
@kadaffy

Description

@kadaffy

When you configure postgres-exporter using the option PG_EXPORTER_AUTO_DISCOVER_DATABASES=true make the service open and keep open a connection per each database,

postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:39Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Established new database connection to \"postgres:5432\"." source="postgres_exporter.go:878" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Semantic Version Changed on \"postgres:5432\": 0.0.0 -> 12.4.0" source="postgres_exporter.go:1405" postgres-exporter | time="2020-09-21T10:09:40Z" level=info msg="Starting Server: :9187" source="postgres_exporter.go:1672" 
$ psql -h localhost -p 5432 -U postgres -c 'select state, usename, datname, count(*) from pg_stat_activity group by state, usename, datname order by usename;' state | usename | datname | count --------+-------------------+----------+------- active | postgres | postgres | 1 | postgres | | 1 idle | postgres_exporter | postgres | 1 idle | postgres_exporter | test1 | 1 idle | postgres_exporter | test2 | 1 idle | postgres_exporter | test3 | 1 idle | postgres_exporter | test4 | 1 idle | postgres_exporter | test5 | 1 idle | postgres_exporter | test6 | 1 idle | postgres_exporter | test7 | 1 idle | postgres_exporter | test8 | 1 idle | postgres_exporter | test9 | 1 | | | 4 (13 rows) 

This is a problem because in an environment with many databases you are wasting connections just for the postgres-exporter service instead of open and close this connection every time it collect the metrics which is more efficient to keep the connection open.

This could also apply to the master database the one your using in the DATA_SOURCE_NAME.

postgres-exporter version: v0.8.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions