Skip to content

fix for some AWs that do not complete #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2023
Merged

fix for some AWs that do not complete #658

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09735b4
fix for some AWs that do not complete
asm582 Oct 10, 2023
897e1ba
fix AW to make resources consistent
asm582 Oct 10, 2023
2fc46ba
check AW status instead of jobs
asm582 Oct 10, 2023
e66a7eb
changing jobstatus from jobs to appwrappers
jbusche Oct 11, 2023
10b5a78
Merge pull request #1 from jbusche/adjust_perf
asm582 Oct 11, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix for some AWs that do not complete
  • Loading branch information
@asm582
asm582 committed Oct 10, 2023
commit 09735b433c9780d080af1ed4e0343f92c40a28b9
5 changes: 4 additions & 1 deletion pkg/controller/queuejob/queuejob_controller_ex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,7 +1625,10 @@ func (cc *XController) addQueueJob(obj interface{}) {
}
if latestAw.Status.State != arbv1.AppWrapperStateActive && latestAw.Status.State != arbv1.AppWrapperStateEnqueued && latestAw.Status.State != arbv1.AppWrapperStateRunningHoldCompletion {
klog.V(2).Infof("[Informer-addQJ] Stopping requeue for AW %s/%s with status %s", latestAw.Namespace, latestAw.Name, latestAw.Status.State)
break // Exit the loop
AwinEtcd, err := cc.arbclients.WorkloadV1beta1().AppWrappers(latestAw.Namespace).Get(context.Background(), latestAw.Name, metav1.GetOptions{})
if AwinEtcd.Status.State == latestAw.Status.State && err != nil {
break // Exit the loop
}
}
// Enqueue the latest copy of the AW.
if (qj.Status.State != arbv1.AppWrapperStateCompleted && qj.Status.State != arbv1.AppWrapperStateFailed) && hasCompletionStatus {
Expand Down