Skip to content

Conversation

@asm582
Copy link
Member

@asm582 asm582 commented Sep 1, 2023

Issue link

#620

What changes have been made

We have used DISPATCH_RESOURCE_RESERVATION_TIMEOUT to slowdown preemption based on dispatched condition timestamp

Verification steps

Manual tests

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from asm582. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asm582 asm582 marked this pull request as ready for review September 1, 2023 19:21
@openshift-ci openshift-ci bot requested a review from dimakis September 1, 2023 19:21
@metalcycling
Copy link
Collaborator

This seems unnecesary given that schedulingSpec.requeuing.timeInSeconds does exactly the same thing. You can set that value and MCAD would wait timeInSeconds seconds before initiating preemption and requeuing. Are we sure we want to have two mechanisms to do this?

@asm582 asm582 closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants