Skip to content

Conversation

@asm582
Copy link
Member

@asm582 asm582 commented Aug 1, 2023

Issue link

#534
#525

What changes have been made

deletion of dead code and legacy operator code

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change
@openshift-ci openshift-ci bot requested review from KPostOffice and dmatch01 August 1, 2023 14:34
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefanutti
Copy link
Contributor

Nice!

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@z103cb
Copy link
Contributor

z103cb commented Aug 1, 2023

/approve

@astefanutti
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@asm582: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-hypershift 00b0758 link true /test unit-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@asm582
Copy link
Member Author

asm582 commented Aug 1, 2023

@asm582: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-hypershift00b0758linktrue/test unit-hypershift
Full PR test history. Your PR dashboard.

@astefanutti hypershift CI job is failing, can you please help, I am not sure how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants